refactor: extract the sidebar slice from useStore - #79
Merged
Conversation
Owner
Author
|
@cursor review |
PR Review — Loreframe StudioRisk: low Automated review from Findings
Changed files
CONTRIBUTING checklist
Posted by the repo PR review workflow. Re-runs on each push to the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3975ad6. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultado
Siguiente corte acotado de
useStore:createSidebarSliceenui/src/stores/sidebarSlice.ts.useStore.tssigue siendo la fachada pública (sidebarOpen,toggleSidebar,setSidebarOpen)sidebarOpenarranca enfalseagentActions.tsuseStore.tsVerificación local
npx tsx --tsconfig tsconfig.app.json --import ./tests/setupI18n.ts --test tests/architectureSlices.test.mjs8/8npm test487--max-warnings=0tsc -bpython scripts/architecture_contracts.pyPendiente de CI.
Note
Low Risk
Mechanical store refactor with no API or UI changes; sidebar consumers keep using the same
useStoreselectors.Overview
Moves sidebar open/close state out of
useStoreinto a dedicatedcreateSidebarSlicemodule, matching the existing slice pattern (settings, theme, developer mode).useStorestill exposes the same public API (sidebarOpen,toggleSidebar,setSidebarOpen); behavior is unchanged—in-memory only, defaultsidebarOpen: false. An architecture test asserts the slice and the store facade stay in sync.Reviewed by Cursor Bugbot for commit 3975ad6. Configure here.